Fix fullscreen video absolute position #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tutman96
changed the title
|
Works well, and I really like the Vite proxy override. Since device mode is the primary development mode, we should make it the default. The issue, however, is that developers need to dig into vite.config.ts to understand that there’s a proxy override. To avoid feature creep in this PR, let’s create another one with a wrapper script that prompts the user for a JetKVM IP. If we want to get fancy, we could also store a list of IPs in a dot folder. |
adamshiervani
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21
Updates the absolute mouse position calculation to take into account differing aspect ratio between the video element and the video stream, which happens when fullscreening the screen share.
This also adds
dev:devicepackage.json script to allow doing live-reload against a development JetKVM device. As introduced in #10