Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CI Workflows #52

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

alexevladgabriel
Copy link
Contributor

@alexevladgabriel alexevladgabriel commented Jan 7, 2025

Changelogs:

  • Includes workflows for creating binaries on new releases and pr's for being able to test them.

Workflows:

  • Release
  • Push

@alexevladgabriel alexevladgabriel marked this pull request as draft January 7, 2025 23:07
@Nevexo
Copy link
Contributor

Nevexo commented Jan 7, 2025

Just so it's in the GH history: Discord Thread

PR builds should include the commit hash of the latest commit in the PR's branch

@kashalls
Copy link

kashalls commented Jan 7, 2025

Can you pass both a Version and a Gitsha instead of just the ref?

go build -ldflags "-s -w -X kvm.Version=${VERSION} -X kvm.Gitsha=${REVISION}" ./cmd/main.go

Version is the Semver Tag and Gitsha is the sha of the git commit it is building on.

@alexevladgabriel alexevladgabriel marked this pull request as ready for review January 8, 2025 00:53
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants