refactor(ui): Organize imports and improve code style across components#195
Closed
adamshiervani wants to merge 0 commit intodevfrom
Closed
refactor(ui): Organize imports and improve code style across components#195adamshiervani wants to merge 0 commit intodevfrom
adamshiervani wants to merge 0 commit intodevfrom
Conversation
Contributor
|
After this is merged, we can then enforce it during CI. I've already added the task, it's just commented out in #189. However we don't want to fix the lint during CI, we just want to check it. Since you changed the behavior of Or you could just create a new task called |
adamshiervani
force-pushed
the
chore/upgrade-and-apply-eslint
branch
from
27905b9 to
ba0c937
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait with merge, there are some big pending ones that needs to be merged before.