[DRAFT] Overhaul Keyboard Functionality (For multiple keyboard layouts, and other functionality) #116
Conversation
Store is functioning as expected, adding new layouts should be trivial and easily scalable. Implementation is different for each function that uses the keyboard (PasteModal vs Typing in the WebRTC window) these will all require their own testing.
williamjohnstone
changed the title
Alters ActionBar.tsx to make the CTRL+ALT+DEL button in the Action Bar PR work again with layered with jetkvm#116 - not pulling into the PR until jetkvm#116 has been integrated, but the my PR will probably just be dropped anyway.
|
Please include German Keyboard Layout |
…ted settings.tsx to set the keyboard layout properly.
williamjohnstone
changed the title
|
I have found further issues with the way that keyboard functionality is implemented, therefor the scope of work on this PR has been expanded. I am working on this when I have time, thank you for everyone's continued patience. |
|
This PR will now also resolve #125 |
…teModal to add more clarity to error message. Begin working on key remapping in WebRTC (working to a reasonable degree).
|
Thank you for your help on this, I can test French keyboard if / when needed :) |
… my changes (YAY!). Also spent 4 hours troubleshooting to find out I didn't realise how useCallback works... :/ Anway, not much longer before work on just the mappings can begin.
|
I know this may have been referenced, but I have a number of Hyprland systems I would love to use the JetKVM for but being able to use win/hyper key without the OS taking over would be immensely helpful, I would be happy to help test if you get to a testing phase, I might also be able to pitch in if I can find the time as well, Good Luck. Adding an escape sequence in full screen to exit and send all keystrokes in fullscreen mode to the JetKVM might be a solution. say ctrl+alt+esc to exit fullscreen or the overlay exit button and use current system in windowed mode. |
Yes, working on implementing the Keyboard Web API which should resolve this. the problem is actually getting the browser to capture the keys, by default they are passed straight to the OS and the browser never sees them, which is why currently they don't function |
|
Please add support for Norwegian Bokmål: |
Alters ActionBar.tsx to make the CTRL+ALT+DEL button in the Action Bar PR work again with layered with jetkvm#116 - not pulling into the PR until jetkvm#116 has been integrated, but the my PR will probably just be dropped anyway.
Alters ActionBar.tsx to make the CTRL+ALT+DEL button in the Action Bar PR work again with layered with jetkvm#116 - not pulling into the PR until jetkvm#116 has been integrated, but the my PR will probably just be dropped anyway.
|
|
|
Just wanted to post an update, to let everyone know I haven't abandoned this, just difficult to find the time to work on it currently. |
Never worry about this, we're all incredibly thankful for the time you do spend on it. |
…dded functionality to disable keyboard mapping.
|
@PrinceJunkie German keyboard layout added, the first of a few I have planned. @Nevexo Can you pull these changes into the upcoming jetkvm-next release? I'm keen to get some people testing as I don't have access to different keyboards. I plan to now add many layouts first, to get main functionality working for as many as possible. Then I will move onto adding support for the full screen keyboard API to capture keys like the super key while in fullscreen. Then finally I will add support for the virtual keyboard with mappings |
Will do, I'll get it out ASAP. |
|
|
|
Hopped on a call with @williamjohnstone and tested everything. TLDR; Everything works and it was most likely my cable (3rd party USB C to USB A cable, not the one that ships 🤦)
Thank you! |
…mplement proper modifer key holding.
|
Please support Korean Layout. |
|
Was going to start tinkering when I saw you already did all the hard work, 🙏 thanks 👍 |
|
Thank you very much. |
|
I will not be adding any further keyboard layouts. Currently have UK, UK (Apple), US, German, and Spanish. It is too time consuming to add every layout and is taking time away from working on functionality. Therefor in the next week or so, I will complete the functionality of my changes, and finalise the Spanish layout. Then I will look to merge. The community can then add their own mappings as this is a trivial process. I can assist in the mappings if people are having issues, but do not want to dedicate any more time to working on these mappings myself. |
|
I agree. Once this is done it will provide a good pattern for adding more! |
This PR is to introduce functionality for different keyboard mappings.
If you would like your mapping to be included in the initial PR, let me know and I will try my best.
Fixes #30