feat(EventData): Add MapBodies overload with context #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartelink
changed the title
bartelink
commented
Jan 3, 2025
| @@ -87,7 +87,7 @@ type Compression private () = | |||
| static member EncodeTryCompress<'Event, 'Context>(native: IEventCodec<'Event, ReadOnlyMemory<byte>, 'Context>, [<Optional; DefaultParameterValue null>] ?options) | |||
| : IEventCodec<'Event, EncodedBody, 'Context> = | |||
| let opts = defaultArg options CompressionOptions.Default | |||
| FsCodec.Core.EventCodec.Map(native, (fun x -> Compression.Utf8ToEncodedTryCompress(opts, x)), Func<_, _> Compression.EncodedToUtf8) | |||
| FsCodec.Core.EventCodec.Map(native, (fun d -> Compression.Utf8ToEncodedTryCompress(opts, d)), Func<_, _> Compression.EncodedToUtf8) | |||
bartelink
commented
Jan 3, 2025
| @@ -9,6 +9,9 @@ The `Unreleased` section name is replaced by the expected version of next releas | |||
| ## [Unreleased] | |||
|
|
|||
| ### Added | |||
|
|
|||
| - `Core.EventData.MapEx`: Enable contextual encoding of bodies [#127](https://github.com/jet/FsCodec/pull/127) | |||
bartelink
commented
Jan 3, 2025
| @@ -30,8 +30,10 @@ | |||
| </ItemGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Condition=" '$(Configuration)' == 'Debug' " Include="../FsCodec.Box/FsCodec.Box.fsproj" /> | |||
| <PackageReference Condition=" '$(Configuration)' == 'Release' " Include="FsCodec.Box" Version="[3.0.0, 4.0.0)" /> | |||
| <ProjectReference Include="../FsCodec.Box/FsCodec.Box.fsproj" /> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes additional context to the encoding function.
e.g. For
SystemTextJson.Encoding, this enables theshouldCompresspredicate to control compression based on theEventTypeetcNOTE this is a half way house solution - eventually
IEventDatashould take over ownership ofIsUnfoldandContextfromITimelineEventto afford better control of encoding for DynamoStore and CosmosStore without indirect assumptions