Show an error when stashing with only untracked files present - #6013
Closed
voidstackloop wants to merge 1 commit into
Closed
voidstackloop wants to merge 1 commit into
voidstackloop wants to merge 1 commit into
Conversation
Pressing s (Files.StashAllChanges) called git stash push directly with no guard, unlike every option in the Stash options menu, which first checks IsWorkingTreeDirtyExceptSubmodules() and shows NoFilesToStash otherwise. Plain git stash push ignores untracked files by default, so with only an untracked file selected, git succeeds having stashed nothing (exit 0, no local changes to save), and lazygit's prompt just closes with no feedback (jesseduffield#5883). Add the same guard already used by the equivalent menu item, and add an integration test covering it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pressing s (Files.StashAllChanges) called git stash push directly with no guard, unlike every option in the Stash options menu, which first checks IsWorkingTreeDirtyExceptSubmodules() and shows NoFilesToStash otherwise.
Plain git stash push ignores untracked files by default, so with only an untracked file selected, git succeeds having stashed nothing (exit 0, no local changes to save), and lazygit's prompt just closes with no feedback (#5883).
Add the same guard already used by the equivalent menu item, and add an integration test covering it.
PR Description
Please check if the PR fulfills these requirements
go generate ./...)