Fix rare crash caused by get method of proxy object #5129
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5101
In rare cases the proxy object could get used after being incorrectly removed by the gc
Add stack checks to the start of all function calls
A Regression test is not included because I was unable to reproduce the crash with code that would be readable / easy to understand, only with a marginally simplified version of the example code given in the original issue, and @zherczeg advised against including it:
However I can include it anyways if requested.