Add custom dispatcher to Arraybuffer & Arraybuffer_prototype #4651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisbg
reviewed
Apr 15, 2021
jerry-core/ecma/builtin-objects/ecma-builtin-arraybuffer-prototype.c
Outdated
Show resolved
Hide resolved
|
Please can you change the commit title to |
orkvi
changed the title
|
LGTM (informal) |
rerobika
requested changes
Apr 16, 2021
galpeter
requested changes
Jun 15, 2021
| const ecma_value_t arguments_list_p[], /**< list of arguments | ||
| * passed to routine */ | ||
| uint32_t arguments_number) /**< length of arguments' list */ | ||
| { |
Contributor
There was a problem hiding this comment.
The checks from 108-119 lines (numbering based on the new line counts) seems to be similar in both methods. AFAIK we could extract those changes to this place, just before the switch.
Member
There was a problem hiding this comment.
I second, move the isArrayBuffer validation from the methods to the dispatcher.
rerobika
reviewed
Jun 24, 2021
Member
|
Please rebase. |
orkvi
force-pushed
the
arraybuffer
branch
3 times, most recently
from
c002d5e to
0ada526
Compare
zherczeg
requested changes
Oct 27, 2021
jerry-core/ecma/builtin-objects/ecma-builtin-arraybuffer-prototype.c
Outdated
Show resolved
Hide resolved
| enum | ||
| { | ||
| ECMA_BUILTIN_ARRAYBUFFER_PROTOTYPE_ROUTINE_START = 0, | ||
| ECMA_BUILTIN_ARRAYBUFFER_PROTOTYPE_BYTELENGTH_GETTER, |
Contributor
Author
There was a problem hiding this comment.
Which comments are missing?
| { | ||
| ECMA_BUILTIN_ARRAYBUFFER_ROUTINE_START = 0, | ||
| ECMA_BUILTIN_ARRAYBUFFER_OBJECT_IS_VIEW, | ||
| ECMA_BUILTIN_ARRAYBUFFER_SPECIES_GET, |
Contributor
Author
There was a problem hiding this comment.
Which comments are missing?
JerryScript-DCO-1.0-Signed-off-by: Orkenyi Virag [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JerryScript-DCO-1.0-Signed-off-by: Virag Orkenyi [email protected]