Skip to content

Customizable text on menu bar #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jererobles wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Customizable text on menu bar #4

jererobles wants to merge 1 commit into from

Conversation

@jererobles
Copy link
Owner

@jererobles jererobles commented Nov 6, 2021 •
edited
Loading

User-defined text displayed on the menu bar.

Examples:

  • {icon}: ☺️
  • {temp}: 22.6 °C
  • {icon} {temp} / {co2}: ☺️ 22.6 °C / 700 ppm
  • {icon} {temp} / {dust}: ☺️ 22.6 °C / 6 ug/m³
  • {icon} {temp_f} - {co2}: ☺️ 73 °F - 700 ppm

@jererobles jererobles marked this pull request as draft November 6, 2021 07:29
@dwightmulcahy
Copy link
Contributor

dwightmulcahy commented Nov 8, 2021 •
edited
Loading

I like this idea but think this should take a back seat till you a Preference... menu item is defined so that this can live there.

Issue: #6

@dwightmulcahy
Copy link
Contributor

dwightmulcahy commented Nov 8, 2021

BTW, my idea was that the menu should show TEMP and the sensor value that was out of the norm. If everything is normal it would display the Dust level which is one of the main irritants that most people follow.

@jererobles
Copy link
Owner Author

jererobles commented Nov 9, 2021

Indeed that would be useful. Here in Finland the biggest fluctuation is for Humidity, which causes all sorts of skin complications. Would be nice if you could set your own logic to choose what values to display, some combination of the formatting syntax above + conditional logic, e.g. {temp if temp outside_bounds else dust}

dwightmulcahy
dwightmulcahy reviewed Nov 9, 2021
View reviewed changes
airq/app.py
co2=self.strip_sensor_name(formatted_values[consts.KEY_CO2])
)

@rumps.clicked("Menu bar text...")
Copy link
Contributor

@dwightmulcahy dwightmulcahy Nov 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be the perfect time to make this "Preferences..." and move that into there. IMHO

Repository owner deleted a comment from uday7981 Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dwightmulcahy dwightmulcahy dwightmulcahy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jererobles @dwightmulcahy