Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fp): fixes FP #5925 #5927

Merged
merged 2 commits into from
Sep 6, 2023
Merged

fix(fp): fixes FP #5925 #5927

merged 2 commits into from
Sep 6, 2023

Conversation

ZheSun88
Copy link
Contributor

@ZheSun88 ZheSun88 commented Sep 6, 2023

No description provided.

@boring-cyborg boring-cyborg bot added the core changes to core label Sep 6, 2023
@aikebah aikebah changed the title Fix: fixes FP #5925 fix: fixes FP #5925 Sep 6, 2023
@aikebah aikebah changed the title fix: fixes FP #5925 fix(fp): fixes FP #5925 Sep 6, 2023
aikebah
aikebah approved these changes Sep 6, 2023
View reviewed changes
Copy link
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the PR

@aikebah aikebah added this to the 8.4.1 milestone Sep 6, 2023
@aikebah aikebah merged commit 942f8f1 into jeremylong:main Sep 6, 2023
8 of 9 checks passed
@ZheSun88 ZheSun88 mentioned this pull request Oct 17, 2023
Closed
@jeremylong jeremylong mentioned this pull request Oct 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aikebah aikebah aikebah approved these changes

Assignees
No one assigned
Labels
core changes to core
Projects
None yet
Milestone
8.4.1
Development

Successfully merging this pull request may close these issues.
2 participants
@ZheSun88 @aikebah