Adding Valgrind Issues reporting #1909
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
uhafner
approved these changes
Dec 21, 2024
plugin/src/main/java/io/jenkins/plugins/analysis/warnings/Valgrind.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| /** Descriptor for this static analysis tool. */ | ||
| @Symbol("valgrindParser") |
There was a problem hiding this comment.
Is valgrind already used somewhere else?
There was a problem hiding this comment.
@uhafner I don't think is used at all. I add it because we are using in memory detection leak in iot devices.
There was a problem hiding this comment.
Sorry, I wasn't clear about this: wouldn't it be simpler to use the ID valgrind rather than valgrindParser?
There was a problem hiding this comment.
@uhafner I will repost with all your suggestions. Clean up and make a better commit. Including how use it and use cases
panicking
force-pushed
the
feature/add-valgrind-parser
branch
3 times, most recently
from
1c1e67e to
c919254
Compare
uhafner
approved these changes
Dec 27, 2024
plugin/src/main/java/io/jenkins/plugins/analysis/warnings/Valgrind.java
Outdated
Show resolved
Hide resolved
Allow to use valgrindParser to report memory issues The analytic-model already has the valgrind model. Just extend the plugin to use it. recordIssues sourceCodeRetention: 'LAST_BUILD', tool: valgrind(pattern: "out/test/memcheck.xml"), qualityGates: [[threshold: 1, type: 'TOTAL', criticality: 'FAILURE']] Add Fix copy paste error in JavaDoc from Ullrich Hafner Reviewed-by: Ullrich Hafner <[email protected]> Signed-off-by: Michael Trimarchi <[email protected]>
panicking
force-pushed
the
feature/add-valgrind-parser
branch
from
6d3e5c1 to
23a8658
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use valgrindParser to report memory issues
The analytic-model already has the valgrind model. Just extend the plugin to use it.
recordIssues sourceCodeRetention: 'LAST_BUILD',
tool: Valgrind(pattern: "out/test/memcheck.xml"),
qualityGates: [[threshold: 1, type: 'TOTAL', criticality: 'FAILURE']]
Testing done
Deploy locally on latest jenkins instance version 2.489