Use ArrayList for storing parameters locally
#135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the Java 11-native `List.of` and `List.copyOf` to store a copy of the parameters list locally, which aren't natively supported by XStream serialization, use `ArrayList`, which is natively supported. When returning the parameters, wrap them in an unmodifiable list to avoid unexpected external modifications. This unfortunately means that this class is not "immutable" anymore as the parameters can technically be changed, but the current code does not provide a way to accomplish that.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the Java 11-native
List.ofandList.copyOfto store a copy of the parameters list locally, which aren't natively supported by XStream serialization, useArrayList, which is natively supported. When returning the parameters, wrap them in an unmodifiable list to avoid unexpected external modifications.This unfortunately means that this class is not "immutable" anymore as the parameters can technically be changed, but the current code does not provide a way to accomplish that.
This PR stems from a discussion on #134.
Testing done
Verified using existing unit tests plus local testing to see how the class is serialized out to disk.
Submitter checklist