Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implemented invalidation of uploaded to S3 file among related CDN distributions #74

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

implemented invalidation of uploaded to S3 file among related CDN distributions #74

wants to merge 15 commits into from
+483 −18

Conversation

martazobro
Copy link

No description provided.

martazobro and others added 4 commits November 5, 2015 17:38
@martazobro
Merge pull request #1 from jenkinsci/master
e69e6df 
Update forked s3-plugin
@martazobro
Merge pull request #2 from jenkinsci/master
b08f46f 
Update forked s3-plugin to be up-to-date with Jenkins
implemented CloudFront invalidation among all available distributions
f1d9be5
@martazobro
Merge pull request #3 from martazobro/mz-cloudfrontInvalidation
075ecb5 
implemented CloudFront invalidation among all available distributions
@martazobro martazobro mentioned this pull request Nov 11, 2015
Closed
@martazobro martazobro changed the title added CloudFront invalidation feature implemented invalidation of uploaded to S3 file among related CDN distributions Nov 11, 2015
@martazobro
Copy link
Author

Hello @ndeloof , @bsideup.
We are using s3 as a central resources storage. All files are reached through CDN (CloudFront distributions). It's extremely important of us to invalidate files right after upload, so all caches are updated.
This is what extension does.
The feature might be helpful for others teams as well.
I'm writing to you, guys, as most recent plugin contributors.
Could you, please, take a look and advise me what should i do next to have this feature as part of plugin.

Thank you in advance!
Have a nice day,
Marta

@bsideup
Copy link
Member

bsideup commented Nov 11, 2015

@martazobro at least I see some code style issues. Could you please format it in appropriate way?

@bsideup
Copy link
Member

bsideup commented Nov 11, 2015

@martazobro also, I would prefer to see this as an additional action, not a part of main action. So you will have 2 actions: first one for upload and second one (abstract) for CloudFront invalidation. Reason: users can re-use this action to invalidate cloudfront without uploading.

@martazobro
Copy link
Author

Hi, @bsideup
Implemented CloudFront invalidation as separate action, please, take a look.
Thank you in advance!

bsideup
bsideup reviewed Nov 18, 2015
View reviewed changes
src/main/java/hudson/plugins/s3/cloudfront/InvalidationEntry.java
}

public FormValidation doCheckBucket(@QueryParameter String bucket) {
return checkNotBlank(bucket, "Bucket name must be speified");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo in "speified" :)

@martazobro
Copy link
Author

@bsideup , i've fixed your notations, improved invalidation logic by enabling invalidation paths with wildcard and added possibility to specify comma-separated list of paths.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martazobro @bsideup