Permit uploading artifacts for aborted builds #132
Conversation
| /** | ||
| * Do not publish the artifacts when build is aborted | ||
| */ | ||
| public boolean noUploadOnAborted; |
There was a problem hiding this comment.
To the best of my understanding, this needs to be true in order to preserve the backwards compatibility. However, existing configurations will be migrated so this gets set to false (default value for boolean) causing it to change semantics.
Better use Boolean here and do the null -> true conversion in readResolve: https://wiki.jenkins.io/display/JENKINS/Hint+on+retaining+backward+compatibility#Hintonretainingbackwardcompatibility-Scenario:Addinganewfield
There was a problem hiding this comment.
Just made those changes. Let me know what you think
|
Any update on getting this merged? |
|
@olivergondza bump |
|
@daniel-beck @Jimilian @varyvol Could you help merging/review? |
|
@varyvol, can you please take a look? Thanks! |
|
@varyvol Would you mind to check the PR ? |
|
@alecharp I can see you did latest commits in the repository. |
|
@alecharp @olivergondza bumping this again because we are still in need of this functionality |
|
@rsandell would you mind to review the changes? |
Right now there is a configuration option for overriding the default behavior that prevents uploading artifacts when the build fails. However nonesuch option exists for overriding the same behavior preventing uploading artifacts for aborted builds.
This adds that option so that for aborted builds artifacts can be pushed to S3.