-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom parameters to authorize and logout endpoints #480
Open
eva-mueller-coremedia
wants to merge
12
commits into
jenkinsci:master
Choose a base branch
from
eva-mueller-coremedia:query-params
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add custom parameters to authorize and logout endpoints #480
eva-mueller-coremedia
wants to merge
12
commits into
jenkinsci:master
from
eva-mueller-coremedia:query-params
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #480 +/- ##
============================================
+ Coverage 71.73% 72.78% +1.05%
- Complexity 222 248 +26
============================================
Files 17 17
Lines 1033 1073 +40
Branches 148 152 +4
============================================
+ Hits 741 781 +40
- Misses 201 202 +1
+ Partials 91 90 -1 ☔ View full report in Codecov by Sentry. |
…eld instanceof String'
eva-mueller-coremedia
force-pushed
the
query-params
branch
from
December 14, 2024 23:24
58e2662
to
36fe900
Compare
eva-mueller-coremedia
changed the title
Add custom parameters to authorize and logout endpoint
Add custom parameters to authorize and logout endpoints
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Additionally, some housekeeping (fixing typos, simplify statements) has been done.
The main change has been done in eb0d2ba:
maybeOpenIdLogoutEndpoint
has been refactored when it comes to combining all parametersorg.pac4j.oidc.config.OidcConfiguration
maybeOpenIdLogoutEndpoint
likeid_token_hint
,state
,post_logout_redirect_uri
Testing done
This change has been tested by unit tests as well as local testing agains AWS Cognito.
Submitter checklist