Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71737] make MesosCloud name uneditable #420

Closed
wants to merge 3 commits into from

Conversation

car-roll
Copy link

downstream of jenkinsci/jenkins#8310

Setting MesosCloud.isNameEditable() to false. This will disable the cloud rename page.

Testing done

Submitter checklist

@car-roll
Copy link
Author

Does not look like incrementals is working, may need to way for release

@@ -145,6 +145,11 @@ public MesosCloud(
this.master);
}

@Override
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just comment this out with a TODO and merge the PR whenever doesn't need to be dependent on the core PR

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented out with a TODO in 73d45ab

@timja
Copy link
Member

timja commented Sep 14, 2023

Does not look like incrementals is working, may need to way for release

The Gradle ecosystem only supported incrementals in the last few months and this plugin hasn't been updated for a couple of years

@car-roll car-roll marked this pull request as ready for review September 14, 2023 15:40
@car-roll
Copy link
Author

@timja, do you have merge permissions to this repository? I do not

@car-roll car-roll requested a review from timja September 14, 2023 15:45
@car-roll car-roll closed this Sep 14, 2023
@car-roll car-roll reopened this Sep 14, 2023
@timja
Copy link
Member

timja commented Sep 14, 2023

@timja, do you have merge permissions to this repository? I do not

No I am not a maintainer here

@car-roll car-roll closed this Sep 15, 2023
@car-roll car-roll reopened this Sep 15, 2023
@car-roll
Copy link
Author

cc @jeschkies for review

@car-roll
Copy link
Author

moving to draft and waiting for a non-incremental version to bump this PR to

@car-roll car-roll marked this pull request as draft September 15, 2023 18:34
@car-roll car-roll closed this Jan 26, 2024
@jeschkies
Copy link
Collaborator

@car-roll I'm trying to upgrade Gradle but it's been a while that I've used Java #421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants