Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split one test into two in MarkupTextTest #10226

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Rian-Ismael
Copy link

@Rian-Ismael Rian-Ismael commented Jan 31, 2025

Improves the readability of the test. Splitting assertions into separate tests improves clarity and ensures each test verifies a single scenario or state. This enhances readability, maintainability, and debugging efficiency.

Testing done

Modified automated tests pass with local testing

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

Improves the readability of the test. Splitting assertions into separate tests improves clarity and ensures each test verifies a single scenario or state. This enhances readability, maintainability, and debugging efficiency.
Copy link

welcome bot commented Jan 31, 2025

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@MarkEWaite MarkEWaite added tests This PR adds/removes/updates test cases skip-changelog Should not be shown in the changelog labels Jan 31, 2025
@MarkEWaite MarkEWaite changed the title Update MarkupTextTest.java Split one test into two in MarkupTextTest Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog tests This PR adds/removes/updates test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants