Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete spotbugs exclusion #10224

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

StefanSpieker
Copy link
Contributor

@StefanSpieker StefanSpieker commented Jan 30, 2025

Started to work on the "technical debt" section and wanted to start with the insecure cookies, but it seems this exclusion is not needed anymore. I'm curious if my local setup is not working or if it is indeed obsolete today.

Testing done

Passing CI should be enough

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@StefanSpieker StefanSpieker added the skip-changelog Should not be shown in the changelog label Jan 30, 2025
@StefanSpieker StefanSpieker changed the title Removed obsolete exclusion Removed obsolete spotbugs exclusion Jan 30, 2025
@StefanSpieker StefanSpieker marked this pull request as ready for review January 31, 2025 05:28
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@krisstern
Copy link
Member

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jan 31, 2025
@krisstern krisstern merged commit 85be6b6 into jenkinsci:master Feb 1, 2025
15 checks passed
@StefanSpieker StefanSpieker deleted the INSECURE_COOKIE branch February 1, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants