Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove robust-http-client #10190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

basil
Copy link
Member

@basil basil commented Jan 21, 2025

This tiny library by Kohsuke was not being consumed directly by any Jenkins or CloudBees plugins whose binaries I searched. It was only used internally by ProxyConfiguration#getInputStream, a method no longer called by anything relevant besides https://github.com/jenkinsci/xunit-plugin/blob/4bf589c23c09a1988cf3e641e48d3251563814ac/src/main/java/org/jenkinsci/plugins/xunit/util/DownloadableResourceUtil.java#L66 and https://github.com/jenkinsci/xunit-plugin/blob/4bf589c23c09a1988cf3e641e48d3251563814ac/src/main/java/org/jenkinsci/plugins/xunit/util/DownloadableResourceUtil.java#L66, both of which seem like they could work just fine without a 5-try retry loop.

Testing done

mvn clean verify -Dtest=hudson.ProxyConfigurationManagerGUITest,hudson.ProxyConfigurationManagerTest,hudson.ProxyConfigurationTest

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@basil basil added the removed This PR removes a feature or a public API label Jan 21, 2025
Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@basil LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removed This PR removes a feature or a public API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants