Skip to content

Commit

Permalink
JENKINS-64650: Upgrade Commons FileUpload from 1.3.1-jenkins-2 to 1.4 (
Browse files Browse the repository at this point in the history
…#5174)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
  • Loading branch information
basil and dependabot[bot] authored Feb 1, 2021
1 parent 94c96e2 commit 887296f
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ THE SOFTWARE.
<dependency>
<groupId>commons-fileupload</groupId>
<artifactId>commons-fileupload</artifactId>
<version>1.3.1-jenkins-2</version>
<version>1.4</version>
</dependency>
<dependency>
<groupId>com.sun.xml.txw2</groupId>
Expand Down
3 changes: 3 additions & 0 deletions core/src/main/java/hudson/PluginManager.java
Original file line number Diff line number Diff line change
Expand Up @@ -1771,6 +1771,9 @@ public HttpResponse doUploadPlugin(StaplerRequest req) throws IOException, Servl
File t = File.createTempFile("uploaded", ".jpi");
t.deleteOnExit();
try {
// TODO Remove this workaround after FILEUPLOAD-293 is resolved.
t.delete();

fileItem.write(t);
} catch (Exception e) {
// Exception thrown is too generic so at least limit the scope where it can occur
Expand Down

0 comments on commit 887296f

Please sign in to comment.