Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving unit test coverage over DRY support #941

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

Improving unit test coverage over DRY support #941

wants to merge 46 commits into from

Commits on Oct 11, 2023

  1. Update _helpers.tpl "Jenkins.url" to use TPL function

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    ecc279e View commit details
    Browse the repository at this point in the history

  2. Create unit test jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    b5b94a5 View commit details
    Browse the repository at this point in the history

  3. Update version in Chart.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c83cfdb View commit details
    Browse the repository at this point in the history

  4. Correcting suite syntax in jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    14bf107 View commit details
    Browse the repository at this point in the history

  5. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    55e8b6f View commit details
    Browse the repository at this point in the history

  6. Changing last assert in jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    0e30e94 View commit details
    Browse the repository at this point in the history

  7. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    8bfa4bc View commit details
    Browse the repository at this point in the history

  8. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    e16dcbc View commit details
    Browse the repository at this point in the history

  9. Update version in Chart.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    35391ea View commit details
    Browse the repository at this point in the history

  10. Merge branch 'main' into main

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    2b6c91b View commit details
    Browse the repository at this point in the history

  11. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    c50cf57 View commit details
    Browse the repository at this point in the history

  12. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    013edaf View commit details
    Browse the repository at this point in the history

  13. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    663ca70 View commit details
    Browse the repository at this point in the history

  14. Commenting 'exists' assertion in jenkins-controller-ingress-DRY-test.… 

    …yaml
    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    aa95dfb View commit details
    Browse the repository at this point in the history

  15. Commenting 'isNotNullOrEmpty' assertion in jenkins-controller-ingress… 

    …-DRY-test.yaml
    @Ceddaerrix
    Ceddaerrix authored Oct 11, 2023
    Configuration menu
    Copy the full SHA
    21b2d66 View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2023

  1. Attempt fixing 'matchRegex' assertion in jenkins-controller-ingress-D… 

    …RY-test.yaml
    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    e530b19 View commit details
    Browse the repository at this point in the history

  2. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    286a151 View commit details
    Browse the repository at this point in the history

  3. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    604bbd7 View commit details
    Browse the repository at this point in the history

  4. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1f89fc6 View commit details
    Browse the repository at this point in the history

  5. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    fca2328 View commit details
    Browse the repository at this point in the history

  6. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    7cffa65 View commit details
    Browse the repository at this point in the history

  7. Using 'contains' instead of 'matchRegex' in jenkins-controller-ingres… 

    …s-DRY-test.yaml
    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    326dd81 View commit details
    Browse the repository at this point in the history

  8. Reverting to 'matchRegex' in jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    0a48945 View commit details
    Browse the repository at this point in the history

  9. Editing 'matchRegex' pattern in jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    b4313a6 View commit details
    Browse the repository at this point in the history

  10. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    f1d648c View commit details
    Browse the repository at this point in the history

  11. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c576058 View commit details
    Browse the repository at this point in the history

  12. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    abfdd33 View commit details
    Browse the repository at this point in the history

  13. Update jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    1a7eaf6 View commit details
    Browse the repository at this point in the history

  14. Commenting test case on jcasc-config.yaml in jenkins-controller-ingre… 

    …ss-DRY-test.yaml

Due to limitation in helm-unittest about validating a YAML content into a string field,  the test case on jcasc-config.yaml is momentarily commented.

Nonetheless, a visual validation of https://github.com/jenkinsci/helm-charts/actions/runs/6493066967/job/17633246976?pr=929 actual value shows 'unclassified.location.url' = "https://jenkins.example.com" as expected (https://github.com/jenkinsci/helm-charts/actions/runs/6493066967/job/17633246976?pr=929#step:8:131)
    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c56d7b5 View commit details
    Browse the repository at this point in the history

  15. Removing 'jcasc-config' test case in jenkins-controller-ingress-DRY-t… 

    …est.yaml
    @Ceddaerrix
    Ceddaerrix authored Oct 12, 2023
    Configuration menu
    Copy the full SHA
    c70898d View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Reverting to 'matchRegex' in jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix @CeddaerrixGE
    Ceddaerrix authored and CeddaerrixGE committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b1187de View commit details
    Browse the repository at this point in the history

  2. Editing 'matchRegex' pattern in jenkins-controller-ingress-DRY-test.yaml

    @Ceddaerrix @CeddaerrixGE
    Ceddaerrix authored and CeddaerrixGE committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    eb3d375 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' of https://github.com/Ceddaerrix/helm-charts

    @CeddaerrixGE
    CeddaerrixGE committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    9e8565c View commit details
    Browse the repository at this point in the history

  4. Reintroducing test on jcasc-config with matchRegex

    @CeddaerrixGE
    CeddaerrixGE committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    1c3dba4 View commit details
    Browse the repository at this point in the history

  5. Bumping version

    @CeddaerrixGE
    CeddaerrixGE committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    bf1ba3d View commit details
    Browse the repository at this point in the history

  6. Simplifying jcasc-config matchRegex pattern

    @CeddaerrixGE
    CeddaerrixGE committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b017a33 View commit details
    Browse the repository at this point in the history

  7. Correcting jcasc-config matchRegex path

    @CeddaerrixGE
    CeddaerrixGE committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    62eb1c6 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Simplifying jcasc-config matchRegex pattern

    @CeddaerrixGE
    CeddaerrixGE committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    21fda18 View commit details
    Browse the repository at this point in the history

  2. Improving matchRegex pattern

    @CeddaerrixGE
    CeddaerrixGE committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c3dd3f1 View commit details
    Browse the repository at this point in the history

  3. Improving further matchRegex pattern

    @CeddaerrixGE
    CeddaerrixGE committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    b36f48f View commit details
    Browse the repository at this point in the history

  4. Improving further matchRegex pattern

    @CeddaerrixGE
    CeddaerrixGE committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    375e505 View commit details
    Browse the repository at this point in the history

  5. Improving further matchRegex with simpler pattern

    @CeddaerrixGE
    CeddaerrixGE committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    1bfaa74 View commit details
    Browse the repository at this point in the history

  6. Improving further matchRegex with simpler pattern

    @CeddaerrixGE
    CeddaerrixGE committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    07f736e View commit details
    Browse the repository at this point in the history

  7. Improving further matchRegex with simpler pattern

    @CeddaerrixGE
    CeddaerrixGE committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    3e6bfce View commit details
    Browse the repository at this point in the history

  8. Improving further matchRegex pattern about escaped characters

    @CeddaerrixGE
    CeddaerrixGE committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8eff9eb View commit details
    Browse the repository at this point in the history

  9. Improving further matchRegex pattern about escaped characters

    @CeddaerrixGE
    CeddaerrixGE committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    8059ebf View commit details
    Browse the repository at this point in the history