Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added quotes to the Agent command to prevent defaulting to the sleep #768

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Added quotes to the Agent command to prevent defaulting to the sleep #768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
219bfea
Added quotes to the Agent command to prevent defaulting to the sleep …
papi83dm Dec 7, 2022
ec7a880
Update CHANGELOG.md
papi83dm Dec 7, 2022
ae25475
Merge branch 'main' into main
papi83dm Dec 7, 2022
b82699e
Merge branch 'main' of github.com:papi83dm/helm-charts into main
papi83dm Dec 8, 2022
8ee282a
Merge branch 'main' of github.com:papi83dm/helm-charts into main
papi83dm Dec 8, 2022
da4c462
Fixed trailing space
papi83dm Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion charts/jenkins/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@ Use the following links to reference issues, PRs, and commits prior to v2.6.0.
The change log until v1.5.7 was auto-generated based on git commits.
Those entries include a reference to the git commit to be able to get more details.

## 4.2.17
## 4.2.18

Added quotes to the Agent command to prevent defaulting to the sleep command when the command variable was null.
Updated the unittest to reflect this change.

## 4.2.17
Update Jenkins image and appVersion to jenkins lts release version 2.375.1


Expand Down
2 changes: 1 addition & 1 deletion charts/jenkins/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: jenkins
home: https://jenkins.io/
version: 4.2.17
version: 4.2.18
appVersion: 2.375.1
description: Jenkins - Build great things at any scale! The leading open source automation server, Jenkins provides hundreds of plugins to support building, deploying and automating any project.
sources:
Expand Down
4 changes: 2 additions & 2 deletions charts/jenkins/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ Returns kubernetes pod template configuration as code
- name: "{{ .Values.agent.sideContainerName }}"
alwaysPullImage: {{ .Values.agent.alwaysPullImage }}
args: "{{ .Values.agent.args | replace "$" "^$" }}"
command: {{ .Values.agent.command }}
command: "{{ .Values.agent.command }}"
envVars:
- envVar:
key: "JENKINS_URL"
Expand All @@ -267,7 +267,7 @@ Returns kubernetes pod template configuration as code
- name: "{{ $additionalContainers.sideContainerName }}"
alwaysPullImage: {{ $additionalContainers.alwaysPullImage | default $.Values.agent.alwaysPullImage }}
args: "{{ $additionalContainers.args | replace "$" "^$" }}"
command: {{ $additionalContainers.command }}
command: "{{ $additionalContainers.command }}"
envVars:
- envVar:
key: "JENKINS_URL"
Expand Down
Loading