Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NoProxy configuration #442

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BradyShober
Copy link

Fixes #441

The !proxy.equals(Proxy.NO_PROXY) check does not appear to catch all cases that it should. Explicitly pass the Jenkins No Proxy list through to the client configuration to handle the cases that get past that check.

Testing done

Tested on our live instance with our No Proxy list and confirmed traffic wasn't being sent to the proxy as expected.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jakauppila
Copy link

Any chance of this being merged? It would be useful for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoProxy Configuration Not Working As Expected
2 participants