[JENKINS-33708] Do not call nohup for sh steps running on Windows
#243
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
approved these changes
Nov 22, 2024
jglick
changed the title
nohup for sh steps running on Windows
jglick
reviewed
Nov 22, 2024
| @@ -263,7 +263,7 @@ private List<String> scriptLauncherCmd(ShellController c, FilePath ws, @CheckFor | |||
|
|
|||
| cmdString = cmdString.replace("$", "$$"); // escape against EnvVars jobEnv in LocalLauncher.launch | |||
| List<String> cmd = new ArrayList<>(); | |||
| if (os != OsType.DARWIN) { // JENKINS-25848 | |||
| if (os != OsType.DARWIN && os != OsType.WINDOWS) { // JENKINS-25848 JENKINS-33708 | |||
There was a problem hiding this comment.
🤔 though given
os == OsType.LINUX.
There was a problem hiding this comment.
freebsd could also have nohup.
or would better add pre-step to check if nohup exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://issues.jenkins.io/browse/JENKINS-33708 discussion.