Skip to content

Commit

Permalink
Merge pull request #170 from jenkinsci/fix-missing-userproperty
Browse files Browse the repository at this point in the history
fix NPE when UserHeader not found
  • Loading branch information
mawinter69 authored Jan 3, 2025
2 parents 28534dc + 5f3fffe commit 9c8d868
Showing 1 changed file with 6 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,9 @@ private boolean hasUserLinks() {
User user = User.current();
if (user != null) {
UserHeader userHeader = user.getProperty(UserHeader.class);
return userHeader.getLinks() != null && userHeader.getLinks().size() != 0;
if (userHeader != null) {
return userHeader.getLinks() != null && userHeader.getLinks().size() != 0;
}
}
return false;
}
Expand All @@ -235,7 +237,9 @@ public List<AbstractLink> getUserLinks() {
List<AbstractLink> links = null;
if (user != null) {
UserHeader userHeader = user.getProperty(UserHeader.class);
links = userHeader.getLinks();
if (userHeader != null) {

Check warning on line 240 in src/main/java/io/jenkins/plugins/customizable_header/CustomHeaderConfiguration.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Not covered lines

Lines 224-240 are not covered by tests
links = userHeader.getLinks();
}
}
if (links != null) {
return links;
Expand Down

0 comments on commit 9c8d868

Please sign in to comment.