Skip to content

[FIXED JENKINS-32144] Specify that a task was cancelled when CancellationException happens #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIXED JENKINS-32144] Specify that a task was cancelled when CancellationException happens #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/main/groovy/com/cloudbees/plugins/flow/FlowDSL.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,8 +457,12 @@ public class FlowDelegate {
Result result = final_state.result
results.add(final_state)
current_state.result = current_state.result.combine(result)
} catch(ExecutionException e)
{
} catch(CancellationException e) {
// TODO perhaps rethrow?
current_state.result = FAILURE
listener.error("Failed to run DSL Script: At least one of the tasks of the buildflow was cancelled")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about e.getMessage() in the log. Just for the sake of better logging

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleg-nenashev Is not e.printStackTrace(listener.getLogger()) enough?

e.printStackTrace(listener.getLogger())
} catch(ExecutionException e) {
// TODO perhaps rethrow?
current_state.result = FAILURE
listener.error("Failed to run DSL Script")
Expand Down