Skip to content

Conversation

ueberhammDesign
Copy link

Reopen Pull-Request #59 to squash all together and resolve merge problems.
Original Message:

You can choose the status (Success, Unstable or Failure), which abort the flow build. It also contains, that the build can not be 'better' than any build inside the flow build.

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refactor, I think you only need one method runWithAbortWhenWorseThan { script, abortWhenWorseThan -> ... }

@ueberhammDesign
Copy link
Author

New testcases added.

@dnozay
Copy link
Member

dnozay commented May 3, 2016

@ueberhammDesign

Since I am currently looking for someone else to take over as a maintainer; I will not be the one merging this change. Please check http://jenkins-ci.org/pull-request-greeting.

Side note: I think introducing new features in this plugin is risky and takes away resources that could be better spent on the pipeline plugin. However, please feel free to merge if you are interested in carrying on the flag.

I did look at your changes though, and thank you for addressing my earlier concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants