Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate timestamp.txt #835

Merged
merged 2 commits into from
Jan 29, 2025
Merged

Conversation

daniel-beck
Copy link
Contributor

Last-Modified headers of the metadata files are no longer a reliable indicator of age, as these are different between the different hosts that respond to those requests since recent infra changes (archives/fallback vs. CF).

Downloading all of update-center.actual.json to get the timestamp from #636 is impractical, and wasteful if done repeatedly in a short amount of time.

So this PR adds the new file timestamp.txt that has the same content as the value of .generationTimestamp in update-center.actual.json would be.

@daniel-beck daniel-beck added enhancement This is an enhancement for the tool or wrapper scripts, typically adding features. java This PR affects Java code and would need a new release to be effective labels Jan 24, 2025
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(FTR: caused by jenkins-infra/helpdesk#2649).

LGTM!

@daniel-beck daniel-beck merged commit b05fed6 into jenkins-infra:master Jan 29, 2025
2 checks passed
@@ -112,12 +112,12 @@ function sanity-check {
# This supports updating Jenkins (core) once a year while getting offered compatible plugin updates.
for version in "${WEEKLY_RELEASES[@]}" ; do
# For mainline, advertising the latest core
generate --limit-plugin-core-dependency "$version" --write-latest-core --latest-links-directory "$WWW_ROOT_DIR/dynamic-$version/latest" --www-dir "$WWW_ROOT_DIR/dynamic-$version"
generate --limit-plugin-core-dependency "$version" --write-latest-core --write-timestamp --latest-links-directory "$WWW_ROOT_DIR/dynamic-$version/latest" --www-dir "$WWW_ROOT_DIR/dynamic-$version"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR the changes in this file were stupid as it's still set up to download and run 3.16 without the Java changes.

@daniel-beck daniel-beck added the wrapper PR affects wrapper behavior and will be effective immediately when merged. label Jan 29, 2025
@daniel-beck daniel-beck deleted the timestamp branch January 29, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is an enhancement for the tool or wrapper scripts, typically adding features. java This PR affects Java code and would need a new release to be effective wrapper PR affects wrapper behavior and will be effective immediately when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants