Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(vpc) private subnets: disable IPv6 and experiment around naming #57

Merged

Conversation

dduportal
Copy link
Contributor

@dduportal dduportal commented Dec 5, 2024

This PR has been partially applied to solve the Internet routing problem we faced earlier (ref. jenkins-infra/helpdesk#4319 (comment) and jenkins-infra/helpdesk#4316 (comment)).

It introduces(d) the following changes:

-Disable any IPv6 related feature on the private subnets: we don't need it simplifies the routing private -> NAT gateways -> public -> Egress only / Internet gateways

  • Set up names and tags on the private subnets
    • TODO: same on public subnets. See commented lines

Note: I've added commented line. it's unusual but this PR is more of a "dump stuff to GH" than a real RFE

@dduportal dduportal merged commit 90cf707 into jenkins-infra:main Dec 5, 2024
3 checks passed
@dduportal dduportal deleted the hotfix/disable-ipv6-private-subnets branch December 5, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant