Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ips): provides outbound ips in locals.tf to avoid module usage #23

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

smerle33
Copy link
Contributor

as per jenkins-infra/helpdesk#4320 and to ease the network security, we move the list of outbound ips within locals, to enable auto update with updatecli.

we will need to provide an updatecli manifest to update those data from https://reports.jenkins.io/jenkins-infra-data-reports/azure-net.json

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but blocking to avoid deleting resources created by @smerle33 for the EKS experiment

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes. Your infrastructure matches the configuration.

@dduportal dduportal merged commit 4c533d7 into jenkins-infra:main Nov 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants