Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(updatecli):Track ubuntu 22_04 AMD64 AZ images #1507

Merged
merged 8 commits into from
Nov 26, 2024
Merged

chore(updatecli):Track ubuntu 22_04 AMD64 AZ images #1507

merged 8 commits into from
Nov 26, 2024

Conversation

jayfranco999
Copy link
Collaborator

As per jenkins-infra/helpdesk#4365 (comment)

This PR pins and tracks the latest AZ image for ubuntu 22_04 AMD64

@jayfranco999 jayfranco999 marked this pull request as draft November 11, 2024 17:24
@jayfranco999 jayfranco999 changed the title chore(updatecli):Track ubuntu 22_04 AMD64 images chore(updatecli):Track ubuntu 22_04 AMD64 AZ images Nov 11, 2024
dduportal
dduportal requested changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! Still some work is needed:

  • Blocker: fix the updatecli errors. It looks like the source responds with an empty string on the CI. Not sure if it is an updatecli error, AZ credential error, or something else.
  • Rebase the PR against the latest main reference

updatecli/updatecli.d/az-ubuntu-22-04-amd64-images.yml Show resolved Hide resolved
@jayfranco999
Copy link
Collaborator Author

Update:

The az command to fetch the latest AZ Ubuntu 22_04 AMD64 image now works on infra.ci (https://infra.ci.jenkins.io/job/updatecli/job/packer-images/job/PR-1507/32/pipeline-console/log?nodeId=18)

[2024-11-26T10:11:51.136Z] #################################################
[2024-11-26T10:11:51.136Z] # BUMP AZURE `UBUNTU 22.04` AMD64 IMAGE VERSION #
[2024-11-26T10:11:51.136Z] #################################################
[2024-11-26T10:11:51.136Z] 
[2024-11-26T10:11:51.136Z] source: source#lastReleaseVersion
[2024-11-26T10:11:51.136Z] -------------------------
[2024-11-26T10:12:23.134Z] The shell 🐚 command "/bin/sh /tmp/updatecli/bin/fe287e953d07bf4def15ea4f2d79cd182990dee39f04530a41f3a8f0e0944d01.sh" ran successfully with the following output:
[2024-11-26T10:12:23.134Z] ----
[2024-11-26T10:12:23.134Z] 22.04.202410020
[2024-11-26T10:12:23.134Z] ----
[2024-11-26T10:12:23.134Z] ✔ shell command executed successfully
[2024-11-26T10:12:23.134Z] 
[2024-11-26T10:12:23.134Z] target: target#updateVersion
[2024-11-26T10:12:23.134Z] --------------------
[2024-11-26T10:12:23.134Z] [transformers]
[2024-11-26T10:12:23.134Z] ✔ Result correctly transformed from "22.04.202410020" to "\"22.04.202410020"
[2024-11-26T10:12:23.134Z] ✔ Result correctly transformed from "\"22.04.202410020" to "\"22.04.202410020\""
[2024-11-26T10:12:23.134Z] 
[2024-11-26T10:12:23.134Z] **Dry Run enabled**
[2024-11-26T10:12:23.134Z] 
[2024-11-26T10:12:23.134Z] ⚠ - change detected:
[2024-11-26T10:12:23.134Z] 	* key "$.azure.ubuntu.'22.04'.amd64" should be updated from "\"latest\"" to "\"22.04.202410020\"", in file "./images-versions.yaml"
[2024-11-26T10:12:23.134Z]

@jayfranco999 jayfranco999 marked this pull request as ready for review November 26, 2024 10:16
@jayfranco999
chore(updatecli):Track images
18908aa 
Signed-off-by: jayfranco999 <[email protected]>
@jayfranco999
fixup
772caca 
Signed-off-by: jayfranco999 <[email protected]>
@jayfranco999
fixup
4d95628 
Signed-off-by: jayfranco999 <[email protected]>
@jayfranco999
fixup
5bebcf5 
Signed-off-by: jayfranco999 <[email protected]>
@jayfranco999
fixup
8c2e868 
Signed-off-by: jayfranco999 <[email protected]>
@jayfranco999
fixup
47cf6c0 
Signed-off-by: jayfranco999 <[email protected]>
@jayfranco999 jayfranco999 mentioned this pull request Nov 26, 2024
Closed
4 tasks
dduportal
dduportal approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(2 nitpicking suggestions which I'm going to apply and merge the PR)

LGTM! Nice work!

updatecli/updatecli.d/az-ubuntu-22-04-amd64-images.yml Show resolved Hide resolved
updatecli/updatecli.d/az-ubuntu-22-04-amd64-images.yml Outdated Show resolved Hide resolved
@dduportal dduportal merged commit 272ca80 into jenkins-infra:main Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
chore ubuntu updatecli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayfranco999 @dduportal