Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jenkinsfile):Add updatecli-aws-credentials #1482

Merged

Conversation

jayfranco999
Copy link
Collaborator

As per jenkins-infra/helpdesk#4365 (comment):

This PR integrates updatecli aws credentials once created.

@jayfranco999 jayfranco999 marked this pull request as draft October 28, 2024 07:12
@@ -1,4 +1,4 @@
withCredentials([azureServicePrincipal('updatecli-azure-serviceprincipal')]) {
withCredentials([azureServicePrincipal('updatecli-azure-serviceprincipal'), aws(accessKeyVariable: 'updaecli-aws-access-key-id', secretKeyVariable: 'updatecli-aws-secret-access-key')]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ;)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • use 2 credz. of type secret ("text")

Signed-off-by: jayfranco999 <[email protected]>
Signed-off-by: jayfranco999 <[email protected]>
@dduportal dduportal marked this pull request as ready for review October 28, 2024 15:56
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dduportal dduportal merged commit 0426e1e into jenkins-infra:main Oct 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants