Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ubuntu): Use pinned aws base AMI IDs from images-versions.yaml #1472

Merged
merged 2 commits into from
Oct 24, 2024
Merged

chore(ubuntu): Use pinned aws base AMI IDs from images-versions.yaml #1472

merged 2 commits into from
Oct 24, 2024

Conversation

jayfranco999
Copy link
Collaborator

@jayfranco999 jayfranco999 commented Oct 24, 2024 •
edited
Loading

As per jenkins-infra/helpdesk#4365 (comment)

and #1443

We want to use the aws ubuntu pinned AMI Ids in image-versions.yaml, hence the source_ami is retrieved from there.

@jayfranco999
feat(ubuntu):Pin ubuntu 22.04 AMI ids
8cd8c4e 
Signed-off-by: jayfranco999 <[email protected]>
@jayfranco999
fixup
4a2ea9e 
Signed-off-by: jayfranco999 <[email protected]>
@jayfranco999 jayfranco999 changed the title feat(ubuntu):Pin ubuntu 22.04 AMI ids feat(ubuntu):Use pinned aws ubuntu 22.04 AMI ids Oct 24, 2024
@dduportal dduportal enabled auto-merge (squash) October 24, 2024 16:53
dduportal
dduportal approved these changes Oct 24, 2024
View reviewed changes
Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Checks have started: we can proceed.

(note: I'm changing the title to chore before merging)

@dduportal dduportal changed the title feat(ubuntu):Use pinned aws ubuntu 22.04 AMI ids chore(ubuntu): Use pinned aws base AMI IDs from images-versions.yaml Oct 24, 2024
@dduportal dduportal disabled auto-merge October 24, 2024 16:55
@dduportal dduportal merged commit c1cb5fd into jenkins-infra:main Oct 24, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dduportal dduportal dduportal approved these changes

Assignees
No one assigned
Labels
aws chore ubuntu
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayfranco999 @dduportal