feat(git): compile git instead of relying on apt ppa repository #1180

smerle33 · 2024-05-17T09:00:38Z

compiling git now from tag source on github

smerle33 · 2024-05-20T07:43:41Z

goss : [git][stdout] git version 2.45.1

dduportal · 2024-05-20T07:52:23Z

I'm not sure if it is a blocker or not, but: our images seems to have the git and git-man packages from default Ubuntu APT repositories installed:

[2024-05-17T14:32:00.339Z] �[0;32m2024-05-17T14:32:00Z:     azure-arm.ubuntu: ii  git                                    1:2.34.1-1ubuntu1.10                    amd64        fast, scalable, distributed revision control system�[0m
[2024-05-17T14:32:00.339Z] �[0;32m2024-05-17T14:32:00Z:     azure-arm.ubuntu: ii  git-man                                1:2.34.1-1ubuntu1.10                    all          fast, scalable, distributed revision control system (manual pages)�[0m

It is most probably installed as a dependency from another installation. The goss test seems to indicate the proper (compiled and recent) version is used.

However we should carefully check the following (before going further):

What is the path of the git binary installed by the APT package and is it conflicting, overriden or other by the make install introduced by this change?
What is/are the package(s) requiring git package (as we introduce the implicit installation by removing the PPA installation)
Do we also have the git package from Ubuntu on the latest release (currently in production) 1.63.0 of the packer image?

smerle33 · 2024-05-23T12:00:25Z

I'm not sure if it is a blocker or not, but: our images seems to have the git and git-man packages from default Ubuntu APT repositories installed:

[2024-05-17T14:32:00.339Z] �[0;32m2024-05-17T14:32:00Z:     azure-arm.ubuntu: ii  git                                    1:2.34.1-1ubuntu1.10                    amd64        fast, scalable, distributed revision control system�[0m
[2024-05-17T14:32:00.339Z] �[0;32m2024-05-17T14:32:00Z:     azure-arm.ubuntu: ii  git-man                                1:2.34.1-1ubuntu1.10                    all          fast, scalable, distributed revision control system (manual pages)�[0m

It is most probably installed as a dependency from another installation. The goss test seems to indicate the proper (compiled and recent) version is used.

However we should carefully check the following (before going further):

* What is the path of the `git` binary installed by the APT package and is it conflicting, overriden or other by the `make install` introduced by this change?

* What is/are the package(s) requiring `git` package (as we introduce the implicit installation by removing the PPA installation)

* Do we also have the `git` package from Ubuntu on the latest release (currently in production) 1.63.0 of the packer image?

The git package has a strong dependency with the ubuntu-server package https://packages.ubuntu.com/jammy/ubuntu-server so removing it is not easy.
We already know (and check) that the default git called is the compiled one with goss.

So we can keep both version as the default one will be the compiled one.

smerle33 · 2024-05-27T15:15:10Z

I'm not sure if it is a blocker or not, but: our images seems to have the git and git-man packages from default Ubuntu APT repositories installed:
[2024-05-17T14:32:00.339Z] �[0;32m2024-05-17T14:32:00Z:     azure-arm.ubuntu: ii  git                                    1:2.34.1-1ubuntu1.10                    amd64        fast, scalable, distributed revision control system�[0m
[2024-05-17T14:32:00.339Z] �[0;32m2024-05-17T14:32:00Z:     azure-arm.ubuntu: ii  git-man                                1:2.34.1-1ubuntu1.10                    all          fast, scalable, distributed revision control system (manual pages)�[0m
It is most probably installed as a dependency from another installation. The goss test seems to indicate the proper (compiled and recent) version is used.

However we should carefully check the following (before going further):
* What is the path of the `git` binary installed by the APT package and is it conflicting, overriden or other by the `make install` introduced by this change?

nowhere to find:

root@7deaabfe091c:/# find /  -name git -type f 
/usr/local/bin/git
/usr/local/libexec/git-core/git
root@7deaabfe091c:/# /usr/local/bin/git --version
git version 2.45.1
root@7deaabfe091c:/# /usr/local/libexec/git-core/git --version
git version 2.45.1
root@7deaabfe091c:/#

dpkg -L git
dpkg-query: package 'git' is not installed

in fact it seems that dpkg -l list ALL available package not only installed ones, with their current status :

from the docker container built with this PR (un):

# dpkg -l git
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-=================================
un  git            <none>       <none>       (no description available)

but from the CI (ii) https://infra.ci.jenkins.io/job/infra-tools/job/packer-images/job/PR-1180/19/pipeline-console/log?nodeId=159

[2024-05-23T12:28:53.638Z] �[0;32m2024-05-23T12:28:53Z:     azure-arm.ubuntu: ii  git                                    1:2.34.1-1ubuntu1.10                    amd64        fast, scalable, distributed revision control system�[0m
[2024-05-23T12:28:53.638Z] �[0;32m2024-05-23T12:28:53Z:     azure-arm.ubuntu: ii  git-man                                1:2.34.1-1ubuntu1.10                    all          fast, scalable, distributed revision control system (manual pages)�[0m

un meaning:
first character equal wish u = unkonwn
second character equal current state n = not installed

For Information

	First Character: 
		i: Install
		r: Remove 
		u: Unknown 
		p: Purge 
		h: Hold 
	Second Character: 
		i: Installed 
		c: Config-files exist
		u: Unpacked 
		n: Not Installed
		f: Failed-config 
		h: Half-installed

* What is/are the package(s) requiring `git` package (as we introduce the implicit installation by removing the PPA installation)

* Do we also have the `git` package from Ubuntu on the latest release (currently in production) 1.63.0 of the packer image?

dduportal · 2024-05-28T07:21:20Z

I'm not sure if it is a blocker or not, but: our images seems to have the git and git-man packages from default Ubuntu APT repositories installed:
[2024-05-17T14:32:00.339Z] �[0;32m2024-05-17T14:32:00Z:     azure-arm.ubuntu: ii  git                                    1:2.34.1-1ubuntu1.10                    amd64        fast, scalable, distributed revision control system�[0m
[2024-05-17T14:32:00.339Z] �[0;32m2024-05-17T14:32:00Z:     azure-arm.ubuntu: ii  git-man                                1:2.34.1-1ubuntu1.10                    all          fast, scalable, distributed revision control system (manual pages)�[0m
It is most probably installed as a dependency from another installation. The goss test seems to indicate the proper (compiled and recent) version is used.
However we should carefully check the following (before going further):
* What is the path of the `git` binary installed by the APT package and is it conflicting, overriden or other by the `make install` introduced by this change?

nowhere to find:

root@7deaabfe091c:/# find /  -name git -type f 
/usr/local/bin/git
/usr/local/libexec/git-core/git
root@7deaabfe091c:/# /usr/local/bin/git --version
git version 2.45.1
root@7deaabfe091c:/# /usr/local/libexec/git-core/git --version
git version 2.45.1
root@7deaabfe091c:/#

dpkg -L git
dpkg-query: package 'git' is not installed

in fact it seems that dpkg -l list ALL available package not only installed ones, with their current status :

from the docker container built with this PR (un):

# dpkg -l git
Desired=Unknown/Install/Remove/Purge/Hold
| Status=Not/Inst/Conf-files/Unpacked/halF-conf/Half-inst/trig-aWait/Trig-pend
|/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad)
||/ Name           Version      Architecture Description
+++-==============-============-============-=================================
un  git            <none>       <none>       (no description available)

but from the CI (ii) https://infra.ci.jenkins.io/job/infra-tools/job/packer-images/job/PR-1180/19/pipeline-console/log?nodeId=159

[2024-05-23T12:28:53.638Z] �[0;32m2024-05-23T12:28:53Z:     azure-arm.ubuntu: ii  git                                    1:2.34.1-1ubuntu1.10                    amd64        fast, scalable, distributed revision control system�[0m
[2024-05-23T12:28:53.638Z] �[0;32m2024-05-23T12:28:53Z:     azure-arm.ubuntu: ii  git-man                                1:2.34.1-1ubuntu1.10                    all          fast, scalable, distributed revision control system (manual pages)�[0m

un meaning: first character equal wish u = unkonwn second character equal current state n = not installed

For Information

	First Character: 
		i: Install
		r: Remove 
		u: Unknown 
		p: Purge 
		h: Hold 
	Second Character: 
		i: Installed 
		c: Config-files exist
		u: Unpacked 
		n: Not Installed
		f: Failed-config 
		h: Half-installed

* What is/are the package(s) requiring `git` package (as we introduce the implicit installation by removing the PPA installation)

* Do we also have the `git` package from Ubuntu on the latest release (currently in production) 1.63.0 of the packer image?

As seen together:

In ubuntu packages, git is a dependency of ubuntu-server
Linux Ubuntu container image does not have ubuntu-server package, hence the absence of git
But the VM Ubuntu image has ubuntu-server

From there 2 solutions as we cannot uninstall git on the VMs:

We override the content of the package from our own compilation
We build a local deb package after compiling, and we install this package

smerle33 added 2 commits May 17, 2024 11:00

feat(git): compile git instead of relying on apt ppa repository

d3ef256

move from erased folder

c84bc49

smerle33 marked this pull request as ready for review May 17, 2024 15:37

smerle33 requested a review from dduportal May 17, 2024 15:37

smerle33 mentioned this pull request May 17, 2024

packer-images: git version not always available simultaneously on apt ppa for arm64 and amd jenkins-infra/helpdesk#4100

Open

smerle33 marked this pull request as draft May 20, 2024 09:17

smerle33 and others added 17 commits May 21, 2024 10:51

Merge branch 'main' into git/compile

24c6391

add some debug for git package

b270601

remove default installed packages

f8f21b0

double -

97d025a

more debug

f2edc05

add debug

19a2c3a

use short parameter as long failed

9bb7c1b

shortcut not used build, limit to arm

87cee85

comment and cleanup

fcc6062

remove debug package list as inreadable

1f8b7d3

debug errorcode

4c0f2bd

temporarily remove failfast

4a04ab4

remove errorcode

f20dbd6

remove exceptions

db96d5a

add back failfast and add a goss check on the git package

6dc4268

cleanup

1d26eae

remove removal of git as it is a strong dependency on ubuntu-server

b5a1be8

Merge branch 'main' into git/compile

ca37f6c

Merge branch 'main' into git/compile

e5c9529

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(git): compile git instead of relying on apt ppa repository #1180

feat(git): compile git instead of relying on apt ppa repository #1180

smerle33 commented May 17, 2024 •

edited

Loading

smerle33 commented May 20, 2024

dduportal commented May 20, 2024

smerle33 commented May 23, 2024

smerle33 commented May 27, 2024 •

edited

Loading

dduportal commented May 28, 2024

feat(git): compile git instead of relying on apt ppa repository #1180

Are you sure you want to change the base?

feat(git): compile git instead of relying on apt ppa repository #1180

Conversation

smerle33 commented May 17, 2024 • edited Loading

smerle33 commented May 20, 2024

dduportal commented May 20, 2024

smerle33 commented May 23, 2024

smerle33 commented May 27, 2024 • edited Loading

dduportal commented May 28, 2024

smerle33 commented May 17, 2024 •

edited

Loading

smerle33 commented May 27, 2024 •

edited

Loading