feat(cijenkinsio-agents-2): adding the new kubernetes cluster to infra.ci management #6020
+25
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smerle33
force-pushed
the
cijenkinsio-agents-2/add/kubmanagement
branch
from
94b3579 to
9a73c19
Compare
dduportal
requested changes
Dec 16, 2024
Comment on lines
17
to
9
| nodeSelector: | ||
| kubernetes.io/arch: arm64 | ||
| jenkins: ci.jenkins.io | ||
| role: applications |
There was a problem hiding this comment.
Do we have node pools with these settings?
Comment on lines
55
to
47
| # replicaCount: 2 | ||
|
|
||
| # proxy: | ||
| # dnsResolver: "kube-dns.kube-system.svc.cluster.local 9.9.9.9" |
There was a problem hiding this comment.
Why commenting out these (mandatory) elements?
config/datadog_cijioagents2.yaml
Outdated
| aks: | ||
| enabled: true | ||
| datadog: | ||
| clusterName: 'cijioagents2' |
There was a problem hiding this comment.
Suggested change
| clusterName: 'cijioagents2' | |
| clusterName: 'cijenkinsio-agents-2' |
Ref. https://github.com/jenkins-infra/terraform-aws-sponsorship/blob/main/eks-cijenkinsio-agents-2.tf#L16
We use diminutives for helmfiles but we must keep full FQDNs
config/datadog_cijioagents2.yaml
Outdated
Comment on lines
6
to
10
| env: | ||
| - name: DD_HOSTNAME | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: spec.nodeName |
There was a problem hiding this comment.
Is it needed in the case of EKS? Or is it only AKS?
config/datadog_cijioagents2.yaml
Outdated
Comment on lines
23
to
49
| nodeSelector: | ||
| kubernetes.io/arch: arm64 | ||
| role: applications | ||
| tolerations: | ||
| - key: "ci.jenkins.io/applications" | ||
| operator: "Equal" | ||
| value: "true" | ||
| effect: "NoSchedule" | ||
| agents: | ||
| tolerations: | ||
| # These tolerations are needed to run the agents on the bom node pool | ||
| - key: "ci.jenkins.io/bom" | ||
| operator: "Equal" | ||
| value: "true" | ||
| effect: "NoSchedule" | ||
| - key: "ci.jenkins.io/applications" | ||
| operator: "Equal" | ||
| value: "true" | ||
| effect: "NoSchedule" | ||
| - key: "ci.jenkins.io/agents" | ||
| operator: "Equal" | ||
| value: "true" | ||
| effect: "NoSchedule" | ||
| - key: "CriticalAddonsOnly" | ||
| operator: "Equal" | ||
| value: "true" | ||
| effect: "NoSchedule" |
There was a problem hiding this comment.
Do we have the aforementionned node pools/group/whatever?
smerle33
force-pushed
the
cijenkinsio-agents-2/add/kubmanagement
branch
from
b5c59aa to
eb38fb9
Compare
smerle33
force-pushed
the
cijenkinsio-agents-2/add/kubmanagement
branch
from
b4f7206 to
d85f56c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per jenkins-infra/helpdesk#4319 (comment)
starting adding the new EKS cluster to infra.ci kubernetes-management
kubeconfig added as secrets here https://github.com/jenkins-infra/charts-secrets/commit/a24b1ec79f738ab2b2d01b46ea3111feec1abcb0
and datadog api key here https://github.com/jenkins-infra/charts-secrets/commit/c7505e8517376fd712cea6673d06c0191e5d24a9
need #6021
datadognamespaceusing :