added TODO

changed INNO script output name
jendakol · Feb 17, 2019 · a7439bb · a7439bb
1 parent 5c5c2a5
commit a7439bb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/app/lib/commands/BackupCommandExecutor.scala b/app/lib/commands/BackupCommandExecutor.scala
@@ -130,6 +130,15 @@ class BackupCommandExecutor @Inject()(bsDao: BackupSetsDao,
     }
   }
 
+  // TODO: corner case - what to do with files from other platforms??
+  //  private def isOtherPlatformFile(f: FileTreeNode): Boolean = {
+  //    if (SystemUtils.IS_OS_WINDOWS) {
+  //      f.path.headOption.contains('/')
+  //    } else if (SystemUtils.IS_OS_UNIX) {
+  //      f.path.headOption.exists(_ != '/')
+  //    } else sys.error("Unsupported platform")
+  //  }
+
   private def updateBackupSetFilesList(bsId: Long, paths: Seq[String]): Result[Unit] = {
     val normalized = normalizePaths(paths)
 

diff --git a/windeploy/rbackup-client.iss b/windeploy/rbackup-client.iss
@@ -18,7 +18,7 @@ AppPublisher={#MyAppPublisher}
 DefaultDirName={pf}\RBackupClient
 DefaultGroupName={#MyAppName}
 DisableProgramGroupPage=yes
-OutputBaseFilename=rbackup-client-setup
+OutputBaseFilename=rbackup-client-setup-{#MyAppVersion}
 Compression=lzma
 SolidCompression=yes
 MinVersion=0,5.01sp3