Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix audiobooks folder structure example for book #1157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prahal
Copy link

@prahal prahal commented Oct 12, 2024

A book should be under an Author, even for Audiobooks.


error in Server guide > Media > Books graph - Audiobooks "Books" folder should be under "Author" not "Audiobooks" parent

In https://jellyfin.org/docs/general/server/media/books, I believe

Books
├── Audiobooks
│   ├── Author
│   │   ├── Book1.flac
│   │   └── Book2.flac
│   └── Book
│       ├── Chapter1.flac
│       └── Chapter2.flac
└── Books
    └── Author
        ├── Book1.epub
        ├── Book2.epub
        ├── Book
        │   ├── Book1.epub
        │   ├── cover.ext
        │   └── metadata.opf
        └── Book3.mp3

should be

Books
├── Audiobooks
│   └── Author
│       ├── Book1.flac
│       ├── Book2.flac
│       └── Book
│           ├── Chapter1.flac
│           └── Chapter2.flac
└── Books
    └── Author
        ├── Book1.epub
        ├── Book2.epub
        ├── Book
        │   ├── Book1.epub
        │   ├── cover.ext
        │   └── metadata.opf
        └── Book3.mp3
``

That is in "Server guide > Media > Books" under Audiobooks, the "Books" folder should be under "Author" not "Audiobooks" parent folder.

A book should be under an Author, even for Audiobooks.
@jellyfin-bot
Copy link

Cloudflare Pages deployment

Latest commit 858697b10d19a28e80a6877e6ca31e1a84e607a6
Status ✅ Deployed!
Preview URL https://259c5131.jellyfin-org.pages.dev
Type 🔀 Preview

@felix920506
Copy link
Member

Are you sure that simply throwing a book into the Audiobooks folder won't work?

@prahal
Copy link
Author

prahal commented Nov 1, 2024

Are you sure that simply throwing a book into the Audiobooks folder won't work?

No. But this is not what this bug report is about.

I believe that not putting a non audiobook book under an author folder would also not prevent it from showing up. Still the example for Books always tells to put a book under an author. Why provide a non recommanded example because it could still work in the example to show users how to structure the folders (and not provide the recommended structure for audiobooks in this example to only show the non recommended one?).

The bug report was not about the example not getting the book to show up but only about a bug in the example for the recommended structure.

I cannot spend time checking if indeed the audiobook would show up even if not under an Author for at least a few days, but it is beyond the scope of this bug. Maybe another bug report should be open about the recommended structure not displaying all working cases. This is not the aim of this bug.

I reported this one because to me there was a "typo" in the recommended structure example in the wiki.
By the way, as in the example the book folder does not have the author in its name how would the author be known without this book folder being inside its author folder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants