Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HDR10 and Dolby Vision support for Vidaa OS #6229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdulmueid
Copy link
Contributor

This PR brings HDR10 and Dolby Vision playback on Vidaa OS. The video is properly remuxed and the TV recognizes it correctly.

Samples:

20241018_005726

20241018_005934

@abdulmueid abdulmueid requested a review from a team as a code owner October 19, 2024 23:02
@jellyfin-bot
Copy link
Collaborator

jellyfin-bot commented Oct 19, 2024

Cloudflare Pages deployment

Latest commit 1400f20
Status ✅ Deployed!
Preview URL https://8926aed5.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs

Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it play Dolby Vision or a fallback stream?
If the latter, you need to add DOVIWithHDR10 as here instead of DoVi8.

Have you tried DoVi5 samples?

src/scripts/browserDeviceProfile.js Outdated Show resolved Hide resolved
src/scripts/browserDeviceProfile.js Outdated Show resolved Hide resolved
@abdulmueid
Copy link
Contributor Author

abdulmueid commented Oct 20, 2024

Thanks for the feedback @dmitrylyzo and corrections.

I ran some tests with the following files:
DV 5: https://mega.nz/file/2TYwVSTZ#LBh2CoX3QUfkR_kwey_aim9QWvwk3UpLQozEG9n2ww0
DV 7: https://mega.nz/file/DGJU1BzL#4jtSK9Kvx2N6WuNdnQXyOi4NFEqLIymLrmSK5R8WilY
DV 8 + HDR10plus: Kung Fu Panda 4 movie

  1. DV 5 show green/purple tint and does not detect Dolby Vision or HDR at all
  2. DV 7 falls back to standard HDR
  3. DV 8 with HDR10plus falls back to HDR10plus

These are the findings on my U7QF model (2020) only. Newer models would need more testing.
Based on the findings above, I will make the following changes:

  1. Completely remove DoVi 5 and 8 support.
  2. Add Vidaa to the check for |DOVIWithHDR10 along with Tizen

WIth the above changes, the following happens:

  1. DV 5 reports unsupported range and transcodes but still shows green/purple tint.
  2. DV 7 falls back to standard HDR
  3. DV 8 with HDR10plus falls back to HDR10plus

Copy link

sonarcloud bot commented Oct 20, 2024

@nyanmisaka
Copy link
Member

DV 5 reports unsupported range and transcodes but still shows green/purple tint.

Enabling tone-mapping in Dashboard->Playback should resolve this. JF 10.10 has full support for both software and hardware tone-mapping DV P5 videos.

@abdulmueid
Copy link
Contributor Author

DV 5 reports unsupported range and transcodes but still shows green/purple tint.

Enabling tone-mapping in Dashboard->Playback should resolve this. JF 10.10 has full support for both software and hardware tone-mapping DV P5 videos.

Confirmed. DV 5 displaying well with Tone Mapping.
I thought I had tone mapping enabled but between builds and cache cleans it got disabled.

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants