Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document Ember compatibility adding a peer dep on ember-source #213

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

jelhan
Copy link
Owner

@jelhan jelhan commented Jan 10, 2024

This is not a breaking change. Ember Style Modifier was already documented to only support Ember >= 4.12.0. It only helps consumers to detect early if they are using an unsupported Ember version.

@jelhan jelhan added the enhancement New feature or request label Jan 10, 2024
@jelhan jelhan merged commit abce8c5 into master Jan 10, 2024
11 checks passed
@jelhan jelhan deleted the document-ember-source-compatibility-using-peer-dep branch January 10, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant