Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): add option to provide TX and RX visibility #149

Merged
merged 12 commits into from
Oct 18, 2024
Merged

Conversation

jeertmans
Copy link
Owner

No description provided.

@github-actions github-actions bot added the rust Changes Rust code label Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.63%. Comparing base (3e44c6f) to head (12b8698).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
differt-core/src/rt/graph.rs 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
+ Coverage   80.35%   82.63%   +2.27%     
==========================================
  Files          25       25              
  Lines        1843     1802      -41     
==========================================
+ Hits         1481     1489       +8     
+ Misses        362      313      -49     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Oct 17, 2024

CodSpeed Performance Report

Merging #149 will create unknown performance changes

Comparing tx-rx-vis (12b8698) with main (6306ade)

Summary

🆕 15 new benchmarks

Benchmarks breakdown

Benchmark main tx-rx-vis Change
🆕 test_compute_paths_in_simple_street_canyon_scene[False-20000-0] N/A 1.1 s N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[False-20000-1] N/A 1.8 s N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[False-20000-2] N/A 2.2 s N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[False-None-0] N/A 973.3 ms N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[False-None-1] N/A 2 s N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[False-None-2] N/A 2.1 s N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[True-20000-0] N/A 5.8 ms N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[True-20000-1] N/A 6.6 ms N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[True-20000-2] N/A 2.2 s N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[True-None-0] N/A 685.8 ms N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[True-None-1] N/A 2 s N/A
🆕 test_compute_paths_in_simple_street_canyon_scene[True-None-2] N/A 2.2 s N/A
🆕 test_fermat N/A 6.6 s N/A
🆕 test_image_method N/A 464.1 ms N/A
🆕 test_transmitter_visibility_in_simple_street_canyon_scene N/A 7.1 s N/A

@github-actions github-actions bot added the benchmarks Changes benchmarks label Oct 18, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 18, 2024
"\n",
"mesh_file = \"bruxelles.obj\"\n",
"mesh = TriangleMesh.load_obj(mesh_file)\n",
"\n",
"tx = jnp.array([-40.0, 75, 30.0])\n",
"rx = jnp.array([+20.0, 108.034, 1.50])\n",
"\n",
"mesh.plot(backend=\"vispy\")"
"scene = TriangleScene(transmitters=tx, receivers=rx, mesh=mesh)\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Unpaired symbol: ‘"’ seems to be missing (EN_UNPAIRED_QUOTES)
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-parentheses
Rule: https://community.languagetool.org/rule/show/EN_UNPAIRED_QUOTES?lang=en-US
Category: PUNCTUATION

"\n",
"len(graph.all_paths(from_, to, order + 2))"
"f\"{len(graph.all_paths(from_, to, depth)):.3e}\" # Roughly a quarter of the preview length"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Unpaired symbol: ‘"’ seems to be missing (EN_UNPAIRED_QUOTES)
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-parentheses
Rule: https://community.languagetool.org/rule/show/EN_UNPAIRED_QUOTES?lang=en-US
Category: PUNCTUATION

"\n",
"len(graph.all_paths(from_, to, order + 2))"
"f\"{len(graph.all_paths(from_, to, depth)):.3e}\" # Roughly a quarter of the preview length"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Unpaired symbol: ‘"’ seems to be missing (EN_UNPAIRED_QUOTES)
URL: https://languagetool.org/insights/post/punctuation-guide/#what-are-parentheses
Rule: https://community.languagetool.org/rule/show/EN_UNPAIRED_QUOTES?lang=en-US
Category: PUNCTUATION

@jeertmans jeertmans merged commit 850d02b into main Oct 18, 2024
38 of 41 checks passed
@jeertmans jeertmans deleted the tx-rx-vis branch October 18, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarks Changes benchmarks dependencies documentation Improvements or additions to documentation rust Changes Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant