Skip to content

Bug fix Average #3036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

Bug fix Average #3036

merged 1 commit into from
May 12, 2025

Conversation

SNatis
Copy link
Contributor

@SNatis SNatis commented Feb 19, 2025

Description

Suggested changelog entry

The statement "count($args) > 2" is present when the function average has only two arguments. When adding the "round" argument, this statement was not adapted. Specifying a rounding in the arguments of the average function causes it to systematically distort the results.

Related issues/external references

Fixes #

Types of changes

  • Bug fix (non-breaking change which fixes)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
    • This change is only breaking for integrators, not for external standards or end-users.
  • Documentation improvement

PR checklist

The statement "count($args) > 2" is present when the function average has only two arguments. When adding the "round" argument, this statement was not adapted.
Specifying a rounding in the arguments of the average function causes it to systematically distort the results.
@Sekiro-kost Sekiro-kost self-requested a review May 7, 2025 09:14
Copy link
Contributor

@Sekiro-kost Sekiro-kost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly

@Sekiro-kost Sekiro-kost merged commit 551355c into jeedom:alpha May 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants