Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linaria update to 3.x version #16

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

hazratgs
Copy link

Hi guys!
Linaria has been updated to version 3.x for a long time and conceptually changed its approach to work, after which the craco-linaria plugin stopped working

I made the necessary edits to work with linaria 3.x, please accept the edits

@codecov
Copy link

codecov bot commented Jan 21, 2021

Codecov Report

Merging #16 (8462cbf) into master (00c35d3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #16   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines           22        22           
=========================================
  Hits            22        22           
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00c35d3...8462cbf. Read the comment docs.

Copy link

@elektronik2k5 elektronik2k5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except for .npmrc.

@@ -0,0 +1 @@
registry = "https://npm.docdoc.pro/"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this change is relevant to the project.

@BeeMargarida
Copy link

BeeMargarida commented Nov 21, 2022

Is this still ongoing? Any possibility of supporting Linaria@4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants