replace with button #240
replace with button #240
Conversation
|
|
||
| .collapse-video { | ||
| left: 30px; | ||
| left: calc(-100vw); |
There was a problem hiding this comment.
Can you please explain what that does?
There was a problem hiding this comment.
This ensures that the chat icon will remain on the left even if the viewport width changes. E.g., if you have a tiling window manager and open a new window, without it firefox will display the icon on the right of the window.
Given the changes from this PR to what it is now, you would use left: calc(-100vw + 10px); instead of left: inherit; (now that the parent has left: 10px;.
| overflow-y: hidden; | ||
|
|
||
| } | ||
| .sidenav.invisible { |
There was a problem hiding this comment.
We already have .invisible, so isn't this redundant?
| cursor: pointer; | ||
| overflow: hidden; | ||
| white-space: pre; | ||
| display: block; |
|
|
||
| function openNav() { | ||
| document.getElementById("sidebarnav").style.width = "250px"; | ||
| //document.getElementById("sidebarnav").style.width = "250px"; |
There was a problem hiding this comment.
Please don't leave commented-out code. Why is this being removed?
|
|
||
| function closeNav() { | ||
| document.getElementById("sidebarnav").style.width = "0"; | ||
| //document.getElementById("sidebarnav").style.width = "0"; |
There was a problem hiding this comment.
Please don't leave commented-out code.
| // return; | ||
| // } else { | ||
| // openNav(); | ||
| // } |
There was a problem hiding this comment.
Please don't leave commented-out code.
3 participants
The html file has now button instead of div, ...
At one place the replacement what not possible (volume with vol on/off + slider)
The aspect and function for the web page with button don't change.