Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended dht_get_nodes() parameters to get also a node id. #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

raspopov
Copy link
Contributor

Both new parameters are optional and can be NULL.

@raspopov
Copy link
Contributor Author

raspopov commented Jun 2, 2015

Do you mean a CHANGES file or something else?

@jech
Copy link
Owner

jech commented Aug 19, 2015

Yes, I mean the README.

@fonic
Copy link
Contributor

fonic commented Apr 3, 2018

How about simply exposing struct node and return a list of all nodes? Then, the application can decide which information it needs. This would also allow for better monitoring as struct node contains other interesting data, e.g. when was the last reply etc.

This could be added additionally instead of modifying dht_nodes to keep compatibilty, e.g.:

int dht_get_nodelist(struct node *nodelist, int nodelistsize);

or

int dht_get_nodelist(struct node *nodelist, int nodelistsize, struct node *nodelist6, int nodelistsize6);

I'd be happy to finish this pull request and/or implement the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants