docs: clarify contribution fit#681
Conversation
📝 WalkthroughWalkthroughThis PR adds initial contribution guidance to the repository. The new ChangesContribution Guidelines
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryAdds contributing guidance to the repository and docs site. A minimal stub
Confidence Score: 5/5Documentation-only change; no runtime or application code is touched. All three changed files are Markdown or a single-line config addition. The new content is internally consistent, the VitePress link resolves to the newly added page, and there are no code paths affected. No files require special attention. Important Files Changed
Reviews (9): Last reviewed commit: "docs: make contributing guide canonical" | Re-trigger Greptile |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@CONTRIBUTING.md`:
- Line 20: Update the CONTRIBUTING.md instruction to list the exact pre-PR
commands to run: add the four commands "mise r build", "mise r test", "mise r
render", and "mise r lint" (in that order) so contributors know to run the
render task that enforces a clean-diff; also mention that "mise r ci" currently
runs only "test" and "lint" and therefore is not a full replacement for running
build and render locally. Ensure the new text replaces or augments the existing
sentence "Run the checks listed in the repository before opening a PR." with the
explicit command list and the note about mise r ci.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: fc135934-1617-4389-b5ae-d5a3a33e7745
📒 Files selected for processing (1)
CONTRIBUTING.md
| mise install | ||
| ``` | ||
|
|
||
| Run the checks listed in the repository before opening a PR. |
There was a problem hiding this comment.
Specify the exact checks to run before opening a PR.
Line 20 advises to "run the checks listed in the repository," but does not enumerate them. Looking at the CI pipeline in .github/workflows/test.yml and mise.toml, contributors should run:
mise r build
mise r test
mise r render
mise r lintThe render task is particularly important—it has a clean-diff assertion in CI, so running it locally prevents failed checks. Alternatively, if mise r ci is intended as the primary pre-submission command, note that it currently depends only on test and lint, omitting build and render.
✏️ Proposed fix to clarify the checks
Run the checks listed in the repository before opening a PR.
+
+```sh
+mise r build
+mise r test
+mise r render
+mise r lint
+```🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@CONTRIBUTING.md` at line 20, Update the CONTRIBUTING.md instruction to list
the exact pre-PR commands to run: add the four commands "mise r build", "mise r
test", "mise r render", and "mise r lint" (in that order) so contributors know
to run the render task that enforces a clean-diff; also mention that "mise r ci"
currently runs only "test" and "lint" and therefore is not a full replacement
for running build and render locally. Ensure the new text replaces or augments
the existing sentence "Run the checks listed in the repository before opening a
PR." with the explicit command list and the note about mise r ci.
af0fe28 to
bcbc57d
Compare
bcbc57d to
5711825
Compare
Summary
Tests
Note
Low Risk
Documentation-only; no runtime, auth, or data-handling changes.
Overview
Adds contributor-facing documentation and surfaces it on the docs site.
Root
CONTRIBUTING.mdis a short GitHub-facing stub that links readers to the full guide at usage.jdx.dev/contributing.docs/contributing.mdis the full guide: discuss direction in Discord before large PRs, CI and AI review must be green before maintainer review, explicit stance on scope/fit and feature bloat,hk/miseworkflow, Conventional Commits, and testing expectations.VitePress sidebar gains a Contributing item pointing at
/contributing.Reviewed by Cursor Bugbot for commit 215b491. Bugbot is set up for automated code reviews on this repo. Configure here.