-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Swift 4.2 #22
Open
giginet
wants to merge
10
commits into
jdhealy:master
Choose a base branch
from
giginet:swift5
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giginet
changed the title
Drop supporting for Swift 3.x
Drop supporting for Swift 3.x and Swift 4
Feb 1, 2019
giginet
changed the title
Drop supporting for Swift 3.x and Swift 4
Migrate to Swift 4.2
Feb 1, 2019
Any progress on this? The broken XCode 10.2 carthage/build support is pretty annoying for me. |
I'm away while a few days. I'll fix this next week. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this library supports Swift 3.x.
However, Xcode 10.2 drops supporting for Swift 3.x.
So we can't build Carthage on Xcode 10.2 because of this library.
This PR make it dropping Swift 3.x and Xcode 8.x/9.x supporting.