Fix (?) timezone issue for datetime #114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
objects from datetime and date columns are returned as Date objects, but Date objects is just bad.
The mariadb timezone can be specified on the system and mysql library can pass a timezone as connection option, but let's keep it simple for now :
As Date are construct with "local" timezone, imagine the following date:
Formating this with
.toISOString()
will give us"2019-12-31T23:00:00.000Z"
(ISO string is UTC+0 for JS), but we do want only the local value.We do implement a small date utility function to format the date that use the "Y-m-d H:i:s" format.
In the future, we might want to use another library, like temporal, luxon or dare-fns, but for the moment the helper works fine 👌