Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various tweaks/fixes #11

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Various tweaks/fixes #11

merged 1 commit into from
Nov 23, 2023

Conversation

porter707
Copy link

Hi,

I encountered some issues while trying to use this:

  • The workspaceUsers API call was missing an "s"
  • I have a user with the status NOT_REGISTERED which wasn't in the list of valid user statuses, this also meant that some information was missing for that user so I added some defaults / nulls
  • I also had some issues with getting time entries, in progress tasks didn't have an end time and also I don't use some of the other things like tags so I added defaults for them (I believe this also resolves this: $projectsIds, $tagsIds and $taskId must be nullable in TimeEntryDtoImpl #10)

jdecool
jdecool approved these changes Nov 23, 2023
View reviewed changes
Copy link
Owner

@jdecool jdecool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdecool jdecool merged commit 9a8abe5 into jdecool:master Nov 23, 2023
@jdecool
Copy link
Owner

jdecool commented Nov 23, 2023

Thanks @porter707

I need to upgrade this library

@porter707 porter707 deleted the not-registered-users branch November 23, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdecool jdecool jdecool approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@porter707 @jdecool