Add onNavigate function to register event handlers #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tkers, thanks for the PRs! I went ahead and gave you commit access to this repo so feel free to merge these yourself :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
onNavigatefunction to the included script, enabling themes to add new functionality a bit more easily. I currently could not find a nice way to achieve running a function when navigating to another slide, other than monkey patchingwindow.history.replaceStatewhich is pretty ugly (events likewindow.onpopstateare not triggered when pushing/replacing a new state).Granted, this is not the cleanest solution either, so definitely open for alternatives or suggestions.