Feature/no slide looping #154
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…low looping around the end of the presentation (in either direction)
| var ALLOW_LOOPING = true; | ||
|
|
||
| /** | ||
| * Navigates forward n pages |
There was a problem hiding this comment.
Was going to ask why not just use 1 for FIRST_SLIDE but, ack!, this method is weird. I like your solution :)
There was a problem hiding this comment.
Yeah, since it uses relative values, "1" means "advance one slide", so had to pick values outside any useful range. I suppose if someone ends up with a 10,000,000 slide presentation there will be problems with this feature, but it seems like that's a fair "bug" to leave latent.
|
Heya @barneyb, Thanks for this! Sorry for not reviewing sooner. I just made a couple small stylistic comments, but the code looks good to me. Thanks for the README changes too 👍 |
|
Will merge later this afternoon when I'm at my computer, thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the new
loopoption is set false, don't loop around from last slide to first (or the reverse), and allow jumping directly to first/last slide using Home/End respectively